Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sourceRoot of dist to fix mapping warnings #305

Closed
wants to merge 1 commit into from

Conversation

anthwinter
Copy link

This will ensure .map file sources are set to the dist folder, rather than the src folder. Fixes #303


Thanks for contributing to rrule!

To submit a pull request, please verify that you have done the following:

  • Merged in or rebased on the latest master commit
  • Linked to an existing bug or issue describing the bug or feature you're
    addressing
  • Written one or more tests showing that your change works as advertised
  • Run yarn build to rebuild the dist/ files

This will ensure .map file sources are set to the dist folder, rather than the src folder. Fixes jkbrzt#303
@anthwinter
Copy link
Author

I'm not 100% sure on how to get this tested. I have tested this version on the reproduction repo here: https://github.com/anthw/rrule-map-issue which shows no warnings anymore.

@codecov-io
Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #305 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   89.91%   89.91%           
=======================================
  Files          28       28           
  Lines        1943     1943           
  Branches      580      580           
=======================================
  Hits         1747     1747           
  Misses        196      196

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c839d54...9203e7f. Read the comment docs.

@davidgoli
Copy link
Collaborator

Sorry this has taken me a while to get to, it will probably have to wait until after the holidays.

@davidgoli
Copy link
Collaborator

Thanks for your submission! I think this addresses the issue, however, I wanted a way to manually test the sourcemaps, so I made #310 so the demo also can be debugged using the same sourcemaps. Please let me know if that branch works for you or not. Thanks!

@davidgoli
Copy link
Collaborator

Superceded by #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants